path: remove StringPrototypeCharCodeAt from more posix methods#63662
Open
whoekage wants to merge 1 commit into
Open
path: remove StringPrototypeCharCodeAt from more posix methods#63662whoekage wants to merge 1 commit into
whoekage wants to merge 1 commit into
Conversation
Extends the optimization applied to posix.extname in nodejs#54546 to posix.dirname, posix.basename, and posix.relative. nodejs#54668 covers posix.resolve, posix.normalize, and posix.parse. Replacing `StringPrototypeCharCodeAt(path, i) === CHAR_FORWARD_SLASH` with `path[i] === '/'` is consistently faster on V8 because the single-character string comparison hits a faster path than the integer comparison after charCodeAt(). Benchmark (Apple M1, 30 runs via benchmark/compare.js): dirname-posix: path='/foo' +12.45% *** path='/foo/bar/baz/asdf/quux' +8.82% *** path='/foo/bar' +8.82% *** path='foo' +6.34% * path='foo/bar' +2.26% * basename-posix: pathext='/foo/bar/baz/asdf/quux.html|.html' +8.38% *** pathext='/foo/.bar.baz|.baz' +8.25% *** pathext='/foo/.bar.baz' +6.90% *** pathext='foo/bar.' +5.94% *** pathext='foo' +5.78% * relative-posix: paths='/var|/bin' +3.28% ** No regressions in Win32 paths (slow path untouched). Control benchmark on extname (unchanged) shows ±2% noise without significance, confirming methodology.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the optimization landed in #54546 (
posix.extname) to the remaining POSIX path methods still usingStringPrototypeCharCodeAt. #54668 coversresolve/normalize/parse; this PR coversdirname,basename, andrelative.What changed
Replaced
StringPrototypeCharCodeAt(path, i) === CHAR_FORWARD_SLASHwithpath[i] === '/'in three POSIX methods. Diff: +12 / −14 lines inlib/path.js.Benchmark
Apple M1, 30 runs via
benchmark/compare.js. Showing significant cases:dirname-posix
/foo/foo/bar/baz/asdf/quux/foo/barfoofoo/barbasename-posix
/foo/bar/baz/asdf/quux.html|.html/foo/.bar.baz|.baz/foo/.bar.bazfoo/bar.foorelative-posix
/var|/binMethodology validation
Control benchmark on
extname-posix(unchanged in this PR) shows ±2% deltas without statistical significance, confirming methodology. No regressions on Win32 paths (slow path untouched).Test plan
parallel/test-path*— all 17 passparallel/test-url-*— all 15 passparallel/test-fs-readfile/stat/realpath— passparallel/test-module-*— all 32 passmake lint-js— cleanRefs: #54546, #54668